Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade xmlBuilder to xmlBuilder2 #269

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Migrate from xmlBuilder to xmlBuilder2 for package.xml generation
xmlBuilder is not maintain anymore, so migrating to xmlBuilder2 is interesting to benefits from performance improvement and security issue fixes

@scolladon scolladon requested a review from mehdicherf as a code owner March 18, 2022 18:05
@scolladon scolladon enabled auto-merge (squash) March 18, 2022 18:07
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #269 (cc61b7a) into main (4bfe6f3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          605       603    -2     
=========================================
- Hits           605       603    -2     
Impacted Files Coverage Δ
src/utils/packageConstructor.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfe6f3...cc61b7a. Read the comment docs.

@scolladon scolladon force-pushed the refactor/xmlBuilder2 branch from d6cc654 to 8605f23 Compare March 18, 2022 18:07
mehdicherf
mehdicherf previously approved these changes Mar 21, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2022

Code Climate has analyzed commit cc61b7a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon merged commit 9e61b3f into main Mar 21, 2022
@scolladon scolladon deleted the refactor/xmlBuilder2 branch March 21, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants